Rename is_{string,boolean} to is_{str,bool} #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the rename of as_{string,boolean} to as_{str,bool}. Fixes
issue serde-rs#126
|
We cannot remove is_string and is_boolean until the next breaking release. Please change the doc comments to indicate that these are deprecated and add is_str and is_bool as new functions. |
|
Are we on a new enough stable to support #[deprecated] ? |
|
Unfortunately not, we have one release to go. The best we can do is probably: #[doc(hidden)]
#[cfg_attr(feature = "unstable",
deprecated(since = "0.8.1",
note="will be removed in 0.9.0; use is_str() instead"))]
fn |
|
(Waiting on the discussion in #126 to update this PR) |
|
Thanks for the PR. Based on #126 (comment) there is a justification for the current names. Also they are consistent with json-rust which famously has a more extensive and better-designed Value API than us, so it can't be so bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the rename of as_{string,boolean} to as_{str,bool}. Fixes
issue #126