This repository was archived by the owner on Jan 6, 2020. It is now read-only.
Allow building bootstrap.php.cache when app/autoload.php is absent #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
reviewed
Mar 16, 2017
Composer/ScriptHandler.php
Outdated
| */ | ||
| protected static function useSymfonyAutoloader(array $options) | ||
| { | ||
| return isset($options['symfony-app-dir']) && is_file($options['symfony-app-dir'].PATH_SEPARATOR.'autoload.php'); |
There was a problem hiding this comment.
no need to use PATH_SEPARATOR
There was a problem hiding this comment.
Oh boy lots of goofs there for that few characters :D one - I meant DIRECTORY_SEPARATOR and two - is_file doesn't care if you just use /. Rebased and replaced with a /.
If app/autoload.php is absent then use the autoload.php in Composer's vendor directory.
|
Heya folks, any news on this? The fabbot failure is unrelated to this diff |
|
Thank you @BPScott. |
fabpot
added a commit
that referenced
this pull request
Apr 23, 2017
… is absent (BPScott) This PR was merged into the 5.0.x-dev branch. Discussion ---------- Allow building bootstrap.php.cache when app/autoload.php is absent If app/autoload.php is absent then use the autoload.php in Composer's vendor directory. symfony/symfony#21837 opens the door for removing `app/autoload.php` in Symfony apps. I tried removing that and updating the various reference to it in symfony-standard and my app works (:tada:), but when I run composer install/update it complains about the buildBootstrap task expecting to find `app/autoload.php`. This fix tells the buildBootstrap task to use `vendor/autoload.php` if `app/autoload.php` is absent. Commits ------- 257ee2e Allow building bootstrap.php.cache when app/autoload.php is absent
fabpot
added a commit
to symfony/symfony-standard
that referenced
this pull request
Apr 24, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- Remove app/autoload.php Now that symfony/symfony#21837 is merged, app/autoload.php can be removed and replaced with the standard Composer autoloader. ~WAIT! This can't be merged *just* yet, as it throws errors when running the `buildBootstrap` post install/update script. The fix for this is in sensiolabs/SensioDistributionBundle#313. That PR must be merged and this PR must be updated to use a version of SensioDistributionBundle that contains the fix before this is good to go.~ EDIT: sensiolabs/SensioDistributionBundle#313 is merged (as of 24/04), and this PR has been updated to use the latest version of SensioDistributionBundle. This is now good to merge Commits ------- 298f8b2 Remove app/autoload.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If app/autoload.php is absent then use the autoload.php in Composer's
vendor directory.
symfony/symfony#21837 opens the door for removing
app/autoload.phpin Symfony apps. I tried removing that and updating the various reference to it in symfony-standard and my app works (:tada:), but when I run composer install/update it complains about the buildBootstrap task expecting to findapp/autoload.php.This fix tells the buildBootstrap task to use
vendor/autoload.phpifapp/autoload.phpis absent.