Skip to content

AST-4 : PHP wrapper update AST-4 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2022
Merged

AST-4 : PHP wrapper update AST-4 #219

merged 2 commits into from
Jun 8, 2022

Conversation

preetishishodia7
Copy link
Contributor

@preetishishodia7 preetishishodia7 commented Jun 4, 2022

AST-4

Changes in->
GetExtendedClient
getAccount
GetExtendedContactDetails
getSmsCampaign
sendTransacEmail
getCampaignStats
getEmailCampaign
getChildInfo

Added GetExtendedCampaignStatsGlobalStats
Added GetSmsCampaignRecipients
Added NoteId
Added NoteList
Added ScheduleSmtpEmail
Added TaskList

Copy link
Contributor

@shubhamUpadhyayInBlue shubhamUpadhyayInBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please create a changelog that is easier to understand for the end user. Thanks

@preetishishodia7 preetishishodia7 merged commit 2d374f3 into master Jun 8, 2022
@tasinttttttt
Copy link

The changes to getEmailCampaign breaks (at least) the recipients and statistics fields.

Steps to reproduce:

$config = Client\Configuration::getDefaultConfiguration()->setApiKey('api-key', 'API-KEY');
$apiInstance = new \SendinBlue\Client\Api\EmailCampaignsApi(
  new \GuzzleHttp\Client(),
  $config
);
$campaign = $apiInstance->getEmailCampaign($id);
// results recipients having a GetSmsCampaignRecipients type with an empty content

$campaign->getRecipients(); // results in empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants