Skip to content

Conversation

gargi-gupta
Copy link
Contributor

@gargi-gupta gargi-gupta commented Oct 31, 2017

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@thinkingserious
Copy link
Contributor

@gargi-gupta

We can’t merge your PR without the CLA being signed.

[ ] Sign the CLA before November 3rd
[ ] Tag @mbernier and @thinkingserious to let us know it is signed

Then we will comment with a link to get your shirt!

@gargi-gupta
Copy link
Contributor Author

@mbernier @thinkingserious Signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @gargi-gupta!

If you have not already, please fill out this form to receive your swag.

With Best Regards,

Elmer

@gargi-gupta
Copy link
Contributor Author

gargi-gupta commented Dec 17, 2017 via email

@thinkingserious
Copy link
Contributor

Hello @gargi-gupta,

It looks like we do not have your information in our swag DB. Could you please email us at [email protected] so that we can try to sort this out?

Thanks!

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Feb 28, 2018
@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:36
@thinkingserious thinkingserious changed the title Update SMTPAPI.java chore: Update SMTPAPI.java Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #70 (78a8f26) into main (47db029) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #70   +/-   ##
=========================================
  Coverage     71.84%   71.84%           
  Complexity       37       37           
=========================================
  Files             1        1           
  Lines           103      103           
  Branches          8        8           
=========================================
  Hits             74       74           
  Misses           23       23           
  Partials          6        6           
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/sendgrid/smtpapi/SMTPAPI.java 71.84% <ø> (ø) 37.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47db029...78a8f26. Read the comment docs.

@thinkingserious thinkingserious merged commit d4c076c into sendgrid:main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants