Skip to content

Add/Update Badges on README #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2017
Merged

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Oct 20, 2017

  • - Put the logo at the top of the list
  • - Added License
  • - Added Twitter, Github, and License badges

@mbernier edit:
closes #293

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 20, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 20, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 21, 2017
@jitendra3109
Copy link

@mptap Check your PR for Travis-ci failing.
image

@mptap
Copy link
Contributor Author

mptap commented Oct 22, 2017

@jsroyal: That's a known problem caused by Gradle builds in Travis.
@mbernier: ^^ Let me know if there's anything I can do.

@mbernier
Copy link
Contributor

@mptap if this is something you can fix, we would love you too - it is outside my expertise and @thinkingserious is SLAMMED right now (we have had almost 400 PRs in 21 days)

Double check the PRs though, just in case someone else has picked it up.

@mbernier mbernier merged commit 14dd8c5 into sendgrid:master Oct 22, 2017
@thinkingserious
Copy link
Contributor

Hello @mptap,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/Update Badges on README
5 participants