Skip to content

#75: Document new Git workflow in CHANGELOG.md: #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Hello! Thank you for choosing to help contribute to one of the SendGrid open sou
- [Testing](#testing)
- [Style Guidelines & Naming Conventions](#style-guidelines-and-naming-conventions)
- [Creating a Pull Request](#creating-a-pull-request)
- [Branch Workflow](#branch-naming-pattern)

<a name="roadmap"></a>
We use [Milestones](https://github.com/sendgrid/csharp-http-client/milestones) to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions and additional PRs are welcomed and encouraged.
Expand Down Expand Up @@ -162,6 +163,19 @@ Generally, we follow the style guidelines as suggested by the official language.
```

7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
with a clear title and description against the `master` branch. All tests must be passing before we will review the PR.
with a clear title and description against the `master` branch. All tests must be passing before we will review the PR.
### Please use our Pull Request Template
We use a Pull Request Template also based on GitFlow WorkFlow branches. Check our template at
[Pull Request Template](PULL_REQUEST_TEMPLATE.md).

<a name="branch-naming-pattern"></a>
## Branch Workflow
We are using GitFlow as our Workflow, so we ask you to use our branch naming pattern. Basically, it consists on 2 main branchs and 2 name patterns:
- We have the "master" branch, which is the production branch and the one that is available for using;
- We also have the "development" branch, where all the new features are implemented and tested before going to a release to the "master" branch;
- If you want to create a new feature, please fork from the "development" branch, create a new one using the pattern "feature/#number_of_the_issue" (e.g. "feature/#70") and make your normal pull request;
- If you want to fix a bug that is already in production, create a new branch using the pattern "hotfix/#number_of_the_feature" (e.g. "hotfix/#90").

If you want to learn more about the GitFlow, just access this [website](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow). Just notice that we use "development" instead of "develop" as the branch's name. The "release" branchs will be made by the projects' maintainers.

If you have any additional questions, please feel free to [email](mailto:[email protected]) us or create an issue in this repo.
17 changes: 17 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
We kindly ask you to follow this PR template so we can make the process easier.

## Branch Workflow
We are using GitFlow as our Workflow, so we ask you to use our branch naming pattern. Basically, it consists on 2 main branchs and 2 name patterns:
- We have the "master" branch, which is the production branch and the one that is available for using;
- We also have the "development" branch, where all the new features are implemented and tested before going to a release to the "master" branch;
- If you want to create a new feature, please fork from the "development" branch, create a new one using the pattern "feature/#number_of_the_issue" (e.g. "feature/#70") and make your normal pull request;
- If you want to fix a bug that is already in production, create a new branch using the pattern "hotfix/#number_of_the_feature" (e.g. "hotfix/#90").

If you want to learn more about the GitFlow, just access [this website here](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow). Just notice that we use "development" instead of "develop" as the branch's name. The "release" branchs we'll be made by the projects' maintainers.

## Pull Request
Please refer the issue that the PR is related to on its title and, for the message, explain briefly what you did. For example, if I wanted to make a Pull Request for Issue #75, which is a "bug" and has "Document new Git workflow in CHANGELOG" as title, my branch's name should be "hotfix/#75" and the PR must have this aspects:

**Title**: "#75: Document new Git workflow in CHANGELOG"

**Message**: "Changed the 'CONTRIBUTING' to talk about Branch Flow and created the 'PULL_REQUEST_TEMPLATE' to talk about how the PR should look like."