Avoid sift_down for unmutated PeekMut (rust#75974) #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the change from rust-lang/rust#75974 --
PeekMut
is now constructed withsift: false
, and it is only settrue
byDerefMut
. The same benchmarks are included this PR, and here are my results on this crate:So
bench_find_smallest_1000
is much improved, whilebench_peek_mut_deref_mut
is much worse, just as they found in the standard library. The latter was justified as being "highly artificial" in rust-lang/rust#75974 (review).