-
Notifications
You must be signed in to change notification settings - Fork 369
Source Insert Functions doc added to Functions [DOC-1109] #7686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
|
||
### Using the Sources tab | ||
|
||
You can also create a source insert function from Sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also create a source insert function from Sources. | |
You can create a source insert function from Sources. To create your source insert function from a source: |
|
||
The default source code template includes handlers for all event types. Just implement the types you need and skip the ones you don’t. For event types you want to send through, return the event in the respective event handler. | ||
|
||
### Using the Sources tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to document all of the ways to create a source insert function? You already talk about how to create it using the catalog. Not sure if you need to document how to create it using the sources tab. Normally we just document the most popular way, otherwise we'll constantly be documenting multiple ways.
|
||
> info "Source Insert Function is in Public Beta" | ||
> Source Insert Function is in public beta, and Segment is actively working on this feature. Some functionality may change before it becomes generally available. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't any introductory paragraph that introduces what Source Insert Functions are. Maybe include an intro paragraph that describes what a Source Insert Function is and what it does?
> info "Source Insert Function is in Public Beta" | ||
> Source Insert Function is in public beta, and Segment is actively working on this feature. Some functionality may change before it becomes generally available. | ||
## Create source insert functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get rid of this heading and have the content underneath be a part of the intro
Are you planning on adding this page to the navigation? If so, need to edit one of the navigation files |
Yes! Will work on getting that edited! |
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Proposed changes
Added documentation on Source Insert Functions as part of public beta release
Merge timing