Skip to content

Conversation

@fwkoch
Copy link
Contributor

@fwkoch fwkoch commented Feb 16, 2018

For example, previously if you used an OrderedDict for a properties.Dictionary, it would be coerced to a dict. Now, these classes are maintained.

Container classes still do not allow duck-typing - i.e. you still have to use a subclass of dict, not just something that implements __getitem__, __setitem__, etc.

This addresses @bsmithyman's comment here: #188 (review)

@codecov
Copy link

codecov bot commented Feb 16, 2018

Codecov Report

Merging #221 into dev will decrease coverage by 0.03%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #221      +/-   ##
==========================================
- Coverage   95.08%   95.04%   -0.04%     
==========================================
  Files          15       15              
  Lines        2114     2120       +6     
==========================================
+ Hits         2010     2015       +5     
- Misses        104      105       +1
Impacted Files Coverage Δ
properties/base/containers.py 88.66% <90.9%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90aa13...e997f9d. Read the comment docs.

@fwkoch fwkoch merged commit d4931e9 into dev Feb 16, 2018
@fwkoch fwkoch deleted the feat/keep_container_class branch March 9, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants