Bins Role uses offline keys #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
requested changes
Oct 7, 2019
There was a problem hiding this comment.
The patch itself looks good to me, but there are other places in the document that need to be adopted. Here is one paragraph that's now obsolete:
Each of the "bin" roles SHOULD share the same key as the bins role, due to space efficiency,
and because there is no security advantage to requiring separate keys.
I suggest to grep for all occurrences of "bin" in the text to check for consistency.
|
@lukpueh, when you get a chance, can you re-review and merge if ready? |
trishankatdatadog
requested changes
Oct 9, 2019
pep-0458.txt
Outdated
| @@ -397,8 +398,8 @@ not have any of the keys required to sign for projects. However, it does not | |||
| protect projects from attackers who have compromised PyPI, since attackers can | |||
| manipulate TUF metadata using the keys stored online. | |||
|
|
|||
| This PEP proposes that the *bins* role (and its delegated roles) sign for all | |||
| PyPI projects with an online key. The *targets* role, which only signs with an | |||
| This PEP proposes that the *bins* role's delegated roles sign for all | |||
There was a problem hiding this comment.
Suggested change
| This PEP proposes that the *bins* role's delegated roles sign for all | |
| This PEP proposes that the *bin-n* roles roles sign for all |
Co-Authored-By: Trishank K Kuppusamy <[email protected]>
Co-Authored-By: Trishank K Kuppusamy <[email protected]>
lukpueh
added a commit
that referenced
this pull request
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the image and description so that the bins role uses offline keys