Skip to content

Fix release workflow failed on macos#1347

Merged
tongke6 merged 2 commits intomainfrom
tk/fix-macos-release
Dec 8, 2025
Merged

Fix release workflow failed on macos#1347
tongke6 merged 2 commits intomainfrom
tk/fix-macos-release

Conversation

@tongke6
Copy link
Copy Markdown
Member

@tongke6 tongke6 commented Dec 8, 2025

No description provided.

@tongke6 tongke6 requested a review from a team December 8, 2025 06:12
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @tongke6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue preventing the successful completion of the macOS release workflow. By integrating the installation of the uv package manager into the CircleCI configuration for macOS, it ensures that all necessary dependencies are available, thereby stabilizing the release process and preventing future build failures on this platform.

Highlights

  • Fix macOS Release Workflow: This pull request addresses and fixes a failure in the macOS release workflow within the CircleCI configuration.
  • Install uv on macOS: The fix involves adding steps to install the uv tool, a fast Python package installer and resolver, specifically for the macOS build environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

danqi437
danqi437 previously approved these changes Dec 8, 2025
Copy link
Copy Markdown
Collaborator

@danqi437 danqi437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a step to the macOS release workflow to install uv, fixing a failure. My review points out a security concern with the chosen installation method (wget | sh) and suggests a safer alternative using Homebrew, which is already in use in the same job. This improves security and maintains consistency in the workflow.

oeqqwq
oeqqwq previously approved these changes Dec 8, 2025
Copy link
Copy Markdown
Member

@oeqqwq oeqqwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 8, 2025

@tongke6 I've opened a new pull request, #1348, to work on those changes. Once the pull request is ready, I'll request review from you.

…low (#1348)

# Pull Request

## What problem does this PR solve?

Issue Number: Addresses review feedback on #1347

The macOS release workflow installed `uv` by piping wget output directly
to sh (`wget -qO- https://astral.sh/uv/install.sh | sh`), which executes
unverified scripts from the internet and is vulnerable to compromised
sources or MITM attacks.

## Changes

- Replaced insecure wget installation with `brew install uv`
- Consolidated `uv` installation into existing Homebrew dependencies
step
- Removed separate "Install uv" step

## Possible side effects?

- Performance: None. Installation is now more efficient with one fewer
CI step.

- Backward compatibility: None. This is a CI configuration change only.

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for
you](https://github.com/secretflow/spu/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tongke6 <124763920+tongke6@users.noreply.github.com>
@tongke6 tongke6 dismissed stale reviews from oeqqwq and danqi437 via eb766e6 December 8, 2025 06:36
@tongke6 tongke6 merged commit de427c4 into main Dec 8, 2025
10 checks passed
@tongke6 tongke6 deleted the tk/fix-macos-release branch December 8, 2025 06:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants