-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
PcapNg - Apple Process Information Block #4396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I welcome comments, yet this needs to be tested against several big pcap files before being merged. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4396 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 353 353
Lines 84116 84145 +29
=======================================
+ Hits 68609 68633 +24
- Misses 15507 15512 +5
|
@evverx That's a good catch! Thanks a lot for fuzzing it. This is indeed the piece of the code that I was not able to test. |
Hopefully the action should help to catch things like this automatically. It seems it still crashes. As far as I understand the condition is inverted in that |
68240ec
to
49851d4
Compare
49851d4
to
35cc131
Compare
This is ready to be reviewed. |
This PR adds support for process information stored in a PcapNg by the
tcpdump
command on macOS.How to test it?