Add a simple WebSocketStream::send method to replace Sink trait u…
#144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage And also bump MSRV to 1.64. Fixes #142
sdroege
force-pushed
the
feat/opt-sink-and-future-util
branch
from
bb0b695 to
0c60de0
Compare
Contributor
|
LGTM |
Owner
Author
|
I'll get a release out with this in the next days |
Sytten
reviewed
Nov 28, 2025
| } | ||
|
|
||
| impl<S> WebSocketStream<S> { | ||
| /// Simple send method to replace `futures_sink::Sink` (till v0.3). |
There was a problem hiding this comment.
What does till v0.3 mean in this context?
Contributor
There was a problem hiding this comment.
A new simple Sink API maybe normalized in the future. See #142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sage
And also bump MSRV to 1.64.
Fixes #142