MERSCOPE: adding feature_key attribute for points#210
Merged
LucaMarconato merged 5 commits intoscverse:mainfrom Sep 26, 2024
Merged
MERSCOPE: adding feature_key attribute for points#210LucaMarconato merged 5 commits intoscverse:mainfrom
LucaMarconato merged 5 commits intoscverse:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 35.91% 45.50% +9.59%
==========================================
Files 19 22 +3
Lines 1715 2149 +434
==========================================
+ Hits 616 978 +362
- Misses 1099 1171 +72
|
LucaMarconato
approved these changes
Sep 26, 2024
Member
|
Thanks! I noticed I had made a mistake in the changelog; I fixed it. |
lucas-diedrich
pushed a commit
to lucas-diedrich/spatialdata-io
that referenced
this pull request
Nov 26, 2024
MERSCOPE: adding feature_key attribute for points
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor (but useful) PR: simply passing
"gene"to thefeature_keyargument when parsing the points.