Skip to content

Put back in "Merge pull request #489 from adroitwhiz/touching-white-fixes" #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 26, 2020
Merged

Put back in "Merge pull request #489 from adroitwhiz/touching-white-fixes" #676

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
90040df
Revert "Revert "Revert "Revert "Merge pull request #489 from adroitwh…
fsih Aug 11, 2020
00554df
Handle null bounds
Aug 11, 2020
b119d35
Fix floating point issues near 0
Aug 13, 2020
749b110
Add todo
Aug 13, 2020
5fa9c76
Change local space to clamp to texture space in is touching queries
Aug 13, 2020
b0acea9
Pull in parts of pull 479 which move clamping to texture space into s…
Aug 13, 2020
4a16869
Merge branch 'develop' into pull676
Aug 20, 2020
13d62bd
Add back clamping in sampleColor4b, and handling of values near zero …
Aug 25, 2020
0c73c58
Fix tests on node 12
Aug 25, 2020
63513a9
Add back todo as well
Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Drawable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const getLocalPosition = (drawable, vec) => {
// localPosition matches that transformation.
localPosition[0] = 0.5 - (((v0 * m[0]) + (v1 * m[4]) + m[12]) / d);
localPosition[1] = (((v0 * m[1]) + (v1 * m[5]) + m[13]) / d) + 0.5;
if (Math.abs(localPosition[0] < 1e-8)) localPosition[0] = 0;
if (Math.abs(localPosition[1] < 1e-8)) localPosition[1] = 0;
// Apply texture effect transform if the localPosition is within the drawable's space,
// and any effects are currently active.
if (drawable.enabledEffects !== 0 &&
Expand Down