Don't apply ghost effect to "color is touching color" drawable #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #575
Proposed Changes
This PR re-adds the
effectMask
parameter tosampleColor4b
andtransformColor
, and uses it to mask out the ghost effect for the target drawable ofisTouchingColor
.Reason for Changes
#515 made it so that the ghost effect multiplies all color channels by the ghost effect, not just the alpha value. Because of this, if the ghost effect is applied to a drawable, its colors will change, making the color mask invalid.
This was already fixed on the GPU path (which is why the tests pass), but I overlooked it for the CPU path.
Test Coverage
Waiting on #537 for CPU/GPU parity tests