Put Skin Alter Push Back In #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB: Reverts "Revert "Revert "Revert "Skin alter push"""". |
Some APIs need SVGSkin to update some of its values immediately when changing the SVG. Namely size needs to be synchronously set. However rotation center doesn't need to be set at that time so we can leave it to update where it currently is.
synchronously store SVGRenderer props used in SVGSkin
cwillisf
approved these changes
Sep 25, 2019
cwillisf
deleted the
revert-505-revert-496-revert-493-revert-470-skin-alter-push
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #505
Changes from #470 were taken out again because of a bug where making costume edits in the paint editor were making the costume flash briefly on the stage:
cc / @mzgoddard