Skip to content

Revert "Revert "Skin alter push"" #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 5, 2019

Conversation

kchadha
Copy link
Contributor

@kchadha kchadha commented Aug 13, 2019

Reverts #493

This PR needs investigation as to whether this original PR (e.g. #470) or #467 was failing gui integration tests.

Fix (if necessary) and re-make this PR.

cc/ @cwillisf @mzgoddard

Fix calculateRotationCenter() for SVG skins
Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In its current form, this breaks the costume size indicators in the costume tab:
image

Modifying the costume causes the size indicator to update to an apparently-correct value so it looks like it might be an initialization or order-of-operations issue.

@adroitwhiz
Copy link
Contributor

@cwillisf The costume size indicators are fixed in #497

Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, these fixes seem to do the trick.
Thanks, @mzgoddard and @adroitwhiz!

@cwillisf cwillisf merged commit 928cd60 into develop Sep 5, 2019
@cwillisf cwillisf deleted the revert-493-revert-470-skin-alter-push branch September 5, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants