penStamp() directly to the PenSkin's framebuffer #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh man... How I want stamping to be more efficient! +1 for this kind of optimisation! |
|
Got to say, of this change is at all possible then I would say it is a wonderful win... Being able to stamp faster would be a just amazing. Optimising the change costume, stamp, change costume, stamp loops to be as fast as possible world improve a lot of projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR changes
RenderWebGL.penStampto draw directly to thePenSkin's framebuffer, instead of drawing to the query buffer then drawing the query buffer to thePenSkin's framebuffer as it currently does.Reason for Changes
This improves pen stamp performance by ~2.5-3x, according to this benchmark: