Skip to content

Attach V2 adapters in CPU render playground #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adroitwhiz
Copy link
Contributor

Resolves

Resolves #483

Proposed Changes

This PR attaches adapters for V2 SVGs and bitmap images to the VM in test/integration/cpu-render.html.

Reason for Changes

The VM will not run properly without a V2 bitmap adapter. While the V2 SVG adapter is not strictly necessary, it mirrors the main integration test setup.

Copy link
Contributor

@fsih fsih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fsih fsih merged commit 5c69971 into scratchfoundation:develop Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "cpu-render.html" test playground doesn't work
4 participants