Implement canvas-based TextBubbleSkin #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow this looks great! I am also seeing about a 2x speedup! I tested other language/character sets, line breaks, and it seems to also fix some unusual "jumping" that happens when quickly refreshing the text bubble. |
|
@cwillisf not sure if you want to take a peek at this |
|
Incidentally, this seems to fix garbled text ordering with multi-line say bubbles: scratchfoundation/scratch-vm#1887 |
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-gui#2721 (I think)
Proposed Changes
This PR replaces the SVG text bubble generator with a canvas-based
TextBubbleSkin. This skin is rendered in screen-space and its texture updates synchronously (to the best of my knowledge).Reason for Changes
This removes all the SVG rendering quirks (textures only re-rendering at power-of-two scale factors, weird jaggies, etc.) from text bubbles.
It also improves performance; see Test Bubbles. It's important to note that the old implementation will still be faster in full-screen mode, but only due to a bug in the SVG renderer which renders the text bubbles at 1x scale for the first frame they are shown.
However, the new implementation is significantly faster at the same scale (~2x according to my tests, but more benchmarking would be a good idea).
Test Coverage
I'm not quite sure how to test this! Any guidance is appreciated.