Avoid TypeError when running at PeriodicItemCountMonitor #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time with undefined item_scraped_count stat
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 79.43% 79.43%
=======================================
Files 76 76
Lines 3229 3229
Branches 536 536
=======================================
Hits 2565 2565
Misses 593 593
Partials 71 71 ☔ View full report in Codecov by Sentry. |
Gallaecio
reviewed
Mar 8, 2024
Gallaecio
approved these changes
Mar 8, 2024
…/spidermon into fix/PeriodicItemCountMonitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
However, the monitor will still won't pass until item_scraped_count is defined. I'm not sure if we should include the possibility of wanting this monitor to pass when tresshold is 0 and item_scraped_count is None.