-
Notifications
You must be signed in to change notification settings - Fork 101
Add SNS Action for Spidermon Notifications #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #413 +/- ##
==========================================
+ Coverage 79.14% 79.39% +0.24%
==========================================
Files 74 76 +2
Lines 3175 3222 +47
Branches 530 534 +4
==========================================
+ Hits 2513 2558 +45
- Misses 591 593 +2
Partials 71 71
☔ View full report in Codecov by Sentry. |
|
thought This is not related to this PR specifically, but maybe it would be nice, if we move any action that it is AWS related to a So we could have: Maybe we could discuss this in a separate issue anyway. |
VMRuiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary:
This pull request introduces a new action that allows Spidermon to send notifications via AWS Simple Notification Service (SNS). This provides users with an alternative way to receive notifications and integrate Spidermon with other AWS services or third-party applications through SNS.
Changes:
SendSNSNotificationclass to handle SNS notifications.Benefits:
How to Test:
Looking forward to feedback and any additional changes required.