Desktop notification after the deploy finishes

[wRAR]

As shub deploy is often not finishing fast enough, I tend to run it, switch tasks and forget about it. So it would be good for me if it showed a desktop notification when finishing. The idea is taken from gbp-buildpackage which uses https://pypi.org/project/notify2/ (the code is at https://github.com/agx/git-buildpackage/blob/master/gbp/notifications.py , it's GPL-2+ but it's really trivial and so doesn't need to be copied). I can implement it in my free time, though it's better if someone points me at the file where it should be called.

[elacuesta]

Sounds like a nice feature. Regarding where to put it, my guess it's probably here and here, which are the functions called for "regular" deploys and image-based deploys respectively.

[Gallaecio]

Is it worth implementing into shub?

In cases where you want a notification once a command finishes, it can be trivial to achieve without modifying the actual command by using a command-line program to send the notification right after the command finishes.

For example, with notify-send from libnotify:

shub deploy; notify-send "shub deploy finished"

I personally use KDE’s kdialog instead, to make sure I do not miss it:

shub deploy; kdialog --msgbox "shub deploy finished"

[wRAR]

I think I decided that doing this requires more work for me as a user so it's easier to do this once in shub :)

In any case I'm not using shub anymore so I won't be implementing this feature in the near future, it should be fine to close this.