Added to retrieve using value attribute, fallback. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the New York Times who have malformed it by using value instead of content. See http://www.nytimes.com/2012/06/13/world/middleeast/violence-in-syria-continues-as-protesters-killed.html for an example of this bad code.
scottmac
added a commit
that referenced
this pull request
Feb 18, 2013
Added to retrieve using value attribute, fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra if loop to retrieve description values from sites like New York Times who have malformed it by using value instead of content. See http://www.nytimes.com/2012/06/13/world/middleeast/violence-in-syria-continues-as-protesters-killed.html for an example of this bad code.
Also adapted code from https://github.com/bashofmann to create an easy fallback from pages without og tags to pull the title and description meta tags instead.