Skip to content

Conversation

cajchristian
Copy link
Collaborator

@cajchristian cajchristian commented Jun 11, 2025

This change will update scikit-matter to be compatible with sklearn v 1.7.0, the only change needed was to make DirectionalConvexHull inherit BaseEstimator.

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--257.org.readthedocs.build/en/257/

@PicoCentauri
Copy link
Collaborator

PicoCentauri commented Jun 11, 2025

I think we shoukd set the deps of scikit-learn to >1.7, <1.8 in the pyproject.toml. This at least avoids that the code breaks on the userspace when we are not fast enough to relase a patch

@cajchristian cajchristian requested a review from rosecers June 11, 2025 20:49
Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PicoCentauri PicoCentauri merged commit 18f5d90 into main Jun 12, 2025
12 checks passed
@PicoCentauri PicoCentauri deleted the sklearn-1.7-fixes branch June 12, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants