Skip to content

Conversation

AtharvaRai07
Copy link
Contributor

@AtharvaRai07 AtharvaRai07 commented May 20, 2025

This PR adds a new section describing the chemical properties of the CSD-1000R dataset to the dataset documentation (csd-1000r.rst).
It addresses issue #150 by providing details on chemical composition and bonding environments.

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--249.org.readthedocs.build/en/249/

Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AtharvaRai07!

Chemical Properties
-------------------

The CSD-1000R dataset consists of 100 atomic environments selected from crystal structures in the Cambridge Structural Database (CSD). These environments represent a diverse set of chemical compositions and bonding types, including:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe link the CSD website?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late reply, I have added the link of the csd website and the original research paper.


The dataset captures local chemical environments relevant for modeling properties such as nuclear magnetic resonance (NMR) chemical shieldings, aiding in the understanding of structure-property relationships in materials chemistry.

For more detailed chemical information, users can refer to the original Cambridge Structural Database or the publication by Ceriotti et al. (2019).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also link the paper here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the link in the references section for a legible view.

@PicoCentauri PicoCentauri enabled auto-merge (squash) May 22, 2025 06:33
auto-merge was automatically disabled May 22, 2025 07:25

Head branch was pushed to by a user without write access

@AtharvaRai07
Copy link
Contributor Author

Fix some Sphinx error

@PicoCentauri
Copy link
Collaborator

I think it is complainaing about

/home/runner/work/scikit-matter/scikit-matter/src/skmatter/datasets/descr/csd-1000r.rst:128: 
WARNING: duplicate citation Ceriotti2019, other instance in
/home/runner/work/scikit-matter/scikit-matter/docs/src/bibliography.rst [ref.citation]

@AtharvaRai07
Copy link
Contributor Author

Hmm.. lets see it has some lint error too

Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the linter. If CI is happy we merge.

@PicoCentauri PicoCentauri merged commit b93de9f into scikit-learn-contrib:main May 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants