-
Notifications
You must be signed in to change notification settings - Fork 22
Add chemical properties description to csd-1000r dataset documentation #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chemical properties description to csd-1000r dataset documentation #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AtharvaRai07!
Chemical Properties | ||
------------------- | ||
|
||
The CSD-1000R dataset consists of 100 atomic environments selected from crystal structures in the Cambridge Structural Database (CSD). These environments represent a diverse set of chemical compositions and bonding types, including: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe link the CSD website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late reply, I have added the link of the csd website and the original research paper.
|
||
The dataset captures local chemical environments relevant for modeling properties such as nuclear magnetic resonance (NMR) chemical shieldings, aiding in the understanding of structure-property relationships in materials chemistry. | ||
|
||
For more detailed chemical information, users can refer to the original Cambridge Structural Database or the publication by Ceriotti et al. (2019). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also link the paper here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the link in the references section for a legible view.
Head branch was pushed to by a user without write access
Fix some Sphinx error |
I think it is complainaing about
|
Hmm.. lets see it has some lint error too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing the linter. If CI is happy we merge.
This PR adds a new section describing the chemical properties of the CSD-1000R dataset to the dataset documentation (csd-1000r.rst).
It addresses issue #150 by providing details on chemical composition and bonding environments.
Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--249.org.readthedocs.build/en/249/