Adding PCovC code #245
Closed
Adding PCovC code #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reopening pull request due to errors when pulling/pushing. |
) * Fixed `_ndim_coords_from_arrays` import * Adding `validate_data` calls and tags for CUR, FPS, PCovCUR, and PCovFPS * Adding `validate_data` calls and updated tags to Ridge2FoldCV * Added `validate_data` calls to PCovR * Added `validate_data` calls to KPCovR * Fixing linting * Fix rendering issues and depencies * update pyproject.toml * fix some tests * update runners * fix docs * lint plus warnings as errors * update infra * Updates to fix sklearn branch (scikit-learn-contrib#241) * replacing `self._validate_data` with `validate_data` * Additional fixes * Fixing scikit-learn warnings * Fixing PCovR to work with 1D column vectors * Fixing examples * Changing shape of y in pcovr tests * Fixing PCovR to not mess with data shape --------- Co-authored-by: Christian Jorgensen <[email protected]> * Update pyproject.toml Co-authored-by: Rose K. Cersonsky <[email protected]> * Removing print statement in tests/test_kernel_pcovr.py Co-authored-by: Rose K. Cersonsky <[email protected]> * Fixing artifact in WHO example * Adding test for incorrect score threshold type * Updating test * Fixing validation checks in CUR + FPS * Fix linting * Update coverage collection * Update changelog --------- Co-authored-by: cajchristian <[email protected]> Co-authored-by: Christian Jorgensen <[email protected]> Co-authored-by: Rose K. Cersonsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding PCovC code, examples, and testing suite.
Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--245.org.readthedocs.build/en/245/