Skip to content

Conversation

cajchristian
Copy link
Collaborator

@cajchristian cajchristian commented Feb 10, 2025

Adding fixes for updates with scikit-learn and scipy. Scikit-learn's estimator checks will fail when validate_data is not used. These fixes will pass scikit-learn's estimator checks but are causing unit tests to fail.

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--238.org.readthedocs.build/en/238/

@PicoCentauri
Copy link
Collaborator

I am closing this PR because you are working on a main branch. This is very difficult to contribute to. I am opening another which has the same code on a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants