-
Notifications
You must be signed in to change notification settings - Fork 22
Closed
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency filegood first issueGood for newcomersGood for newcomers
Description
The new ase release break some example notebooks. The ase dependency comes from one roy dataset (see
scikit-matter/src/skmatter/datasets/_base.py
Line 121 in bc76938
def load_roy_dataset(): |
and can easily removed as dependency by just storing the arrays inside the ase frames. We could even try to just use numpys loadtxt, then we don't need to change the binary data file.
Metadata
Metadata
Assignees
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency filegood first issueGood for newcomersGood for newcomers