Merged
Conversation
ariostas
reviewed
Apr 22, 2025
Member
ariostas
left a comment
ariostas
left a comment
There was a problem hiding this comment.
Thank you Ianna! This looks great, but I have a few comments.
To address the formatting and docs comments I left, maybe we should write a noxfile to make it easier for people?
Co-authored-by: Andres Rios Tascon <ariostas@gmail.com>
Co-authored-by: Andres Rios Tascon <ariostas@gmail.com>
Co-authored-by: Andres Rios Tascon <ariostas@gmail.com>
ariostas
approved these changes
Apr 22, 2025
pfackeldey
pushed a commit
that referenced
this pull request
Apr 23, 2025
* docs: add contributing guide * style: pre-commit fixes * Update CONTRIBUTING.md Co-authored-by: Andres Rios Tascon <ariostas@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Andres Rios Tascon <ariostas@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Andres Rios Tascon <ariostas@gmail.com> * use pre-commit * build local documentation howto --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andres Rios Tascon <ariostas@gmail.com>
ianna
added a commit
that referenced
this pull request
Oct 28, 2025
* add tree to virtual array conversion * chore: update pre-commit hooks (#1418) updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.4 → v0.11.5](astral-sh/ruff-pre-commit@v0.11.4...v0.11.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci: pin Chrome version for Pyodide tests (#1422) * Updated Pyodide version * Pinned chrome version * Changed chrome version * Try using node instead of chrome * Remove chrome-specific setup * Actually use Node * Go back to chrome * chore: update pre-commit hooks (#1423) updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.5 → v0.11.6](astral-sh/ruff-pre-commit@v0.11.5...v0.11.6) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: issue with empty big_endian array (#1420) fix issue with empty big_endian array Co-authored-by: Ianna Osborne <ianna.osborne@cern.ch> * fix: safer branch title access (#1421) * safer branch title access * empty str -> None --------- Co-authored-by: Ianna Osborne <ianna.osborne@cern.ch> * docs: add contributing guide (#1425) * docs: add contributing guide * style: pre-commit fixes * Update CONTRIBUTING.md Co-authored-by: Andres Rios Tascon <ariostas@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Andres Rios Tascon <ariostas@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Andres Rios Tascon <ariostas@gmail.com> * use pre-commit * build local documentation howto --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andres Rios Tascon <ariostas@gmail.com> * improve virtual array loading * style: pre-commit fixes * add 'access_log' kwarg * style: pre-commit fixes * don't re-define 'Accessed' * add doc string * minor doc string fixes * use form_with_unique_keys from awkward * rm accidentally committed file... * refactor virtual buffer loading to better work with form mappings * require awkward v2.8.2 * merge main * style: pre-commit fixes * fix pre-commit * add virtual kwarg to avoid API sprawl * satisfy pre-commit * add special single-branch handling like in .arrays(virtual=False) * properly forward the recursive function call for single branch cases * ... also for eager .arrays * add tests * pre-commit * add one test with access_log=None (default) --------- Co-authored-by: Ianna Osborne <ianna.osborne@cern.ch> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andres Rios Tascon <ariostas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like a good idea to add the instructions on how to contribute to the project.