feat: support writing ListArrays to RNTuples#1416
Merged
Conversation
ariostas
commented
Apr 10, 2025
ianna
approved these changes
Apr 11, 2025
Member
ianna
left a comment
ianna
left a comment
There was a problem hiding this comment.
@ariostas - It is a correct way to convert ListArray to ListOffsetArray, though it may not be the most efficient. I'll leave it up to you to decide if you want to leave it as is since it is the internal code, and you may want to optimize it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for writing
ListArrays to RNTuples. RNTuples have an analogue for this, so they are converted toListOffsetArrays before writing them.There are still some array types that can't be written, but each of them requires special handling since again there are no analogues in RNTuple. I'll continue to add them over time.