chore: better error message when writing TBaskets that are too large#1415
Merged
chore: better error message when writing TBaskets that are too large#1415
Conversation
Member
Author
|
@ikrommyd what do you think of these messages? |
Collaborator
I like them, I would probably also mention that the max size is 2GB if that's always the hard limit. I'm not aware of root file internals so I'm not sure if it's 100% correct but if it is, it's useful so that the user knows what they need to at least reduce the size to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1135 there are some discussion about writing batches of data that are too big to fit in a TBasket. I added more detailed error messages so that it is clear what went wrong, since the way it currently crashes is not very informative.