Merged
Conversation
ianna
approved these changes
Apr 8, 2025
| ), | ||
| _rntuple_column_compression_settings_format.pack( | ||
| self.compression_settings | ||
| col[0][3] |
Member
Author
There was a problem hiding this comment.
Yeah, this is pretty ugly. It's one of the things I'll have to refactor since right now it's hard to know what it's doing. But in the interest of getting this PR out since it's kind of important, I'll defer this to the big writing refactoring that I'll start doing soon. Thanks, Ianna!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RNTuple data was being stored fully uncompressed, which was pretty wasteful. This small PR makes it so that it is stored compressed with the compression setting from the file. It would be good to have the option of selecting compression settings in a more granular way (i.e. per field or column), but I'll have to think a bit more how to implement this since it would make more sense to specify it per column, but it would be a lot easier to specify it per field.