Skip to content

test: ATLAS Physlite CI test for RNTuple dev#1411

Merged
ariostas merged 8 commits intoscikit-hep:mainfrom
ArturU043:main
Apr 7, 2025
Merged

test: ATLAS Physlite CI test for RNTuple dev#1411
ariostas merged 8 commits intoscikit-hep:mainfrom
ArturU043:main

Conversation

@ArturU043
Copy link
Copy Markdown
Contributor

Wrote one CI test (test_1396_rntuple_physlite_ATLAS.py) to test the access to ATLAS information within a standard derivation RNTuple.

Using a recently added ATLAS Physlite RNTuple test file to sckit-hep-testdata.

@ArturU043
Copy link
Copy Markdown
Contributor Author

@ariostas

@ArturU043 ArturU043 changed the title ATLAS Physlite CI test for RNTuple dev ci: ATLAS Physlite CI test for RNTuple dev Apr 1, 2025
@ariostas
Copy link
Copy Markdown
Member

ariostas commented Apr 1, 2025

Thanks for the PR, @ArturU043! Could you use math.isclose or numpy.isclose so that the numpy1 tests pass?

Copy link
Copy Markdown
Member

@ariostas ariostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ArturU043! I just had a couple more minor comments

Copy link
Copy Markdown
Member

@ariostas ariostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ArturU043, this looks great!

@ariostas ariostas changed the title ci: ATLAS Physlite CI test for RNTuple dev test: ATLAS Physlite CI test for RNTuple dev Apr 7, 2025
@ariostas ariostas enabled auto-merge (squash) April 7, 2025 13:18
@ariostas ariostas merged commit d330155 into scikit-hep:main Apr 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants