style: Move formatting to Ruff#2627
Closed
matthewfeickert wants to merge 23 commits intoscikit-hep:mainfrom
Closed
style: Move formatting to Ruff#2627matthewfeickert wants to merge 23 commits intoscikit-hep:mainfrom
matthewfeickert wants to merge 23 commits intoscikit-hep:mainfrom
Conversation
Sonnet 4's summary: > The mypy error occurred because the transpose() method on line 659 was > returning a value that mypy inferred as Any, while the function signature > declared it should return ArrayLike. Mypy's no-any-return rule flags when > you return an Any value from a function with a specific return type annotation.
matthewfeickert
added
docs
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2627 +/- ##
==========================================
- Coverage 98.23% 98.13% -0.11%
==========================================
Files 65 65
Lines 4198 4179 -19
Branches 592 455 -137
==========================================
- Hits 4124 4101 -23
- Misses 45 47 +2
- Partials 29 31 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
B007 Loop control variable not used within loop body https://docs.astral.sh/ruff/rules/unused-loop-control-variable/
B011 Do not `assert False` (`python -O` removes these calls), raise `AssertionError()` c.f. https://docs.astral.sh/ruff/rules/assert-false/
B017 Do not assert blind exception: `Exception` https://docs.astral.sh/ruff/rules/assert-raises-exception/
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Temporarily building on top of PR #2625)
Move from Black to Ruff.
As this will be a huge commit this should get ignored afterwards in a
.git-blame-ignore-revsfile.Addresses parts of Issue #2624
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: