feat: Remove support for PyTorch backend#2611
Merged
kratsg merged 18 commits intoscikit-hep:mainfrom Oct 7, 2025
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
==========================================
- Coverage 98.25% 98.23% -0.03%
==========================================
Files 67 65 -2
Lines 4360 4193 -167
Branches 600 591 -9
==========================================
- Hits 4284 4119 -165
+ Misses 46 45 -1
+ Partials 30 29 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matthewfeickert
commented
Oct 3, 2025
| >>> a = pyhf.tensorlib.astensor([[10, 7, 4], [3, 2, 1]]) | ||
| >>> pyhf.tensorlib.percentile(a, 50) | ||
| 3.5 | ||
| np.float64(3.5) |
Member
Author
There was a problem hiding this comment.
Note that docstrings for NumPy got updated as NumPy can now be NumPy v2.0 and so the docstest changed.
78744ce to
d9c025d
Compare
kratsg
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
optimize/opt_pytorch.py.tests/constraints.txt.tests/test_backend_consistency.pyas there is only NumPy and JAX now.Factorizes out parts of PR #2566 and removes additional documentation pieces.
Affected Issues
InvalidBackendexception #2605Please describe the purpose of this pull request in some detail. Reference and link to any relevant issues or pull requests.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: