-
Notifications
You must be signed in to change notification settings - Fork 67
feat: Integrate wheel repairer #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
45d04fd
to
04d9881
Compare
This comment was marked as resolved.
This comment was marked as resolved.
81f9407
to
9cc8ea9
Compare
bf6146a
to
890ee81
Compare
890ee81
to
fc253ec
Compare
fc253ec
to
ccaf24e
Compare
Thanks for this PR. Should it already be working? I tried commits 9700ce0 and b4652c5 and got the following error (with b4652c5):
I set up my pjproject.toml as:
|
It used to work, but I think I did a hasty refactor and broke it. I'll try to get it back to working state this week. There were some unresolved failures, but I don't think there were on the linux builders. There is an issue with patchelf on Fedora distros (and probably many other), but I had a version using |
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
893377e
to
928e504
Compare
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
`auditwheel` pacher forces `DT_RPATH`. Here instead we use `DT_RUNPATH` so that it can be overwritten by the user Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
This is needed because the last delocate package that supports python 3.8 does not have _get_rpaths Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
928e504
to
ce63083
Compare
@FabianSchuetze Could you try again with this branch and/or https://github.com/LecrisUT/scikit-build-core/tree/feat/lief ? |
The goal of this is:
sysconfig.get_path("platlib")
(pip fake venv is really annoying here)
CMAKE_INSTALL_RPATH_USE_LINK_PATH
Scripts
path.Maybe would be better to use the existing paths instead.
Do some other magic thatdelvewheel
doesAfaict, the only special thing it does is inject
os.add_dll_directory
. Cannot supportsubprocess.run
right now, but we could do it if we generate the wrappers. Will make a subsequent PR for that.To discuss:
scikit-build.repair-wheel
?auditwheel
/delocate
/delvewheel
directly, but these do not handle differently the packages in site-package vs externaldlevewheel
which creates separate dlls for each wheel.Depends-on: #1022 #1016