-
Notifications
You must be signed in to change notification settings - Fork 36
Deploy a single py2.py3 wheel per platform #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ready for rebase. Actually, I'd plan on squash and merge anyway, so up to you if you want to rebase or just unmark as draft. The cp27 jobs need to be removed from the required builds (I can do that), and @jcfr this shouldn't affect your upload, right? It should be much simpler, really, with fewer files with longer names, but if there's any automation here, it might beed to be adjusted? |
@henryiii, thanks for the heads up. There's still the "tests for python 2 to ensure incompatibilities are not introduced" I'd rather have before this get merged and now the only reason why this is still marked as draft. With auditwheel 4.0 now in the manylinux images, there's also something weird (2 wheels produced instead of 1) going on with linux aarch64/s390x/ppc64le, I'll |
feded1d
to
8cac369
Compare
Amend previous comment: Given where I'm going with all this, I will add another commit to this PR and hijack a bit the original purpose stated in the title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through the release process, I don't think there's anything else that needs to be changed. I'll adjust the required checks.
You're exactly right. Those are the 2 categories (I initially thought there would be 3, but rewriting the summary let me understand it's 2). Please do rewrite history as you see fit. If you want only 2 commits with these 2 categories, you can also let me know and I'd be happy to do it. |
Thanks for working on this 🙏 💯 I will post few comments/questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ! This will not only reduce the number of packages uploaded but also speed up the CI 💯
Few nitpick/questions:
- Since we already glob the platform, is required to introduce the
dist-staging
directory ? Adding a comment somewhere in the CI config would be nice.
It's indeed unnecessary if we leave the |
Sure, I can do it now. |
Add python 2.7 tests Check exactly 1 final wheel per build exists in ./dist Only rely on auditwheel to add manylinux* platform tags Remove dist-staging
Add `long_description_content_type` to metadata Fixes twine check warning
Main goal:
convert_to_generic_platform_wheel
to convert to apy2.py3
wheel & update jobs not to have python 2.7 jobsOther goals:
long_description_content_type
was missing in the metadata