Skip to content

fix(Alert): padding and icon#6340

Merged
lisalupi merged 3 commits intomainfrom
fix/alert-style
Apr 20, 2026
Merged

fix(Alert): padding and icon#6340
lisalupi merged 3 commits intomainfrom
fix/alert-style

Conversation

@lisalupi
Copy link
Copy Markdown
Collaborator

Summary

Type

  • Bug

Summarize concisely:

What is expected?

Alert: fix padding and icons

@lisalupi lisalupi requested review from a team and mhervouet April 15, 2026 13:23
@lisalupi lisalupi self-assigned this Apr 15, 2026
@lisalupi lisalupi requested a review from jsulpis as a code owner April 15, 2026 13:23
@lisalupi lisalupi requested review from Echo-IV and Lawndlwd and removed request for a team April 15, 2026 13:23
@lisalupi lisalupi added the bug Something isn't working label Apr 15, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 00149a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.65%. Comparing base (27f89d7) to head (00149a4).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6340      +/-   ##
==========================================
+ Coverage   92.57%   92.65%   +0.07%     
==========================================
  Files         533      533              
  Lines        9996    10004       +8     
  Branches     3813     3794      -19     
==========================================
+ Hits         9254     9269      +15     
+ Misses        678      671       -7     
  Partials       64       64              
Files with missing lines Coverage Δ
packages/ui/src/components/Alert/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Alert/styles.css.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bed35...00149a4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jsulpis jsulpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • in medium size the icon size should be 20px, not 24px
Image
  • the close button is always neutral, it should have the sentiment of the Alert
  • the close button is bigger than on Figma but on Figma it's not a button so I'm not sure how to implement that
Image

Copy link
Copy Markdown
Member

@jsulpis jsulpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the icon is too high, you can add a margin-top of 2px like on the small size

Image

@lisalupi lisalupi merged commit 8bca898 into main Apr 20, 2026
15 checks passed
@lisalupi lisalupi deleted the fix/alert-style branch April 20, 2026 08:04
@scaleway-bot scaleway-bot mentioned this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants