Skip to content

fix(EmptyState): avoid empty div#6338

Merged
lisalupi merged 1 commit intomainfrom
fix/empty-state-gap
Apr 14, 2026
Merged

fix(EmptyState): avoid empty div#6338
lisalupi merged 1 commit intomainfrom
fix/empty-state-gap

Conversation

@lisalupi
Copy link
Copy Markdown
Collaborator

Summary

Type

  • Bug

Summarize concisely:

What is expected?

EmptyState: small refactor to avoid empty divs

@lisalupi lisalupi requested review from a team and johnnydoubt April 13, 2026 15:31
@lisalupi lisalupi self-assigned this Apr 13, 2026
@lisalupi lisalupi requested a review from jsulpis as a code owner April 13, 2026 15:31
@lisalupi lisalupi requested review from radhi-nasser-scaleway and vincentaudebert and removed request for a team and jsulpis April 13, 2026 15:31
@lisalupi lisalupi added the bug Something isn't working label Apr 13, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 13, 2026

🦋 Changeset detected

Latest commit: 62ce5bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.65%. Comparing base (27f89d7) to head (62ce5bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6338      +/-   ##
==========================================
+ Coverage   92.57%   92.65%   +0.07%     
==========================================
  Files         533      533              
  Lines        9996    10002       +6     
  Branches     3813     3794      -19     
==========================================
+ Hits         9254     9267      +13     
+ Misses        678      671       -7     
  Partials       64       64              
Files with missing lines Coverage Δ
packages/ui/src/components/EmptyState/index.tsx 96.00% <100.00%> (+1.26%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f89d7...62ce5bb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lisalupi lisalupi merged commit bf1ca25 into main Apr 14, 2026
16 checks passed
@lisalupi lisalupi deleted the fix/empty-state-gap branch April 14, 2026 08:24
@scaleway-bot scaleway-bot mentioned this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants