Skip to content

fix(instance): let the backend resolve marketplace images #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aslafy-z
Copy link

@aslafy-z aslafy-z commented Jun 16, 2025

Remove the client side marketplace image resolution from the CreateServer method.
It's already done at backend level: https://www.scaleway.com/en/developers/api/instance/#path-instances-create-an-instance.

Instance image ID or label. When an image label is used, it will be converted to the latest image available on the Marketplace. By default, the selected local image will be the instance_sbs local image. If an l_ssd volume is specified in the volumes argument, an instance_local local image will be selected instead.

Currently, this code does not resolve conditionally depending on server volumes.

This update mimics the Console behavior, making the backend responsible from selecting the marketplace image.

Fixes #2603

@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Jun 16, 2025
@aslafy-z aslafy-z marked this pull request as ready for review June 16, 2025 17:11
@aslafy-z aslafy-z requested a review from a team as a code owner June 16, 2025 17:11
@aslafy-z aslafy-z changed the title fix(instance): let backend resolve marketplace images fix(instance): let the backend resolve marketplace images Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong marketplace image selection
1 participant