Skip to content

feat(core): positional argument#759

Merged
kindermoumoute merged 11 commits intoscaleway:v2from
kindermoumoute:positional-parameter
Mar 11, 2020
Merged

feat(core): positional argument#759
kindermoumoute merged 11 commits intoscaleway:v2from
kindermoumoute:positional-parameter

Conversation

@kindermoumoute
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread internal/core/cobra_utils.go Outdated
Comment thread internal/core/arg_specs.go
Comment thread internal/core/cobra_utils.go Outdated
Comment thread internal/core/cobra_utils.go Outdated
Comment thread internal/core/cobra_utils.go Outdated
Comment thread internal/core/cobra_utils.go
Comment thread internal/core/cobra_utils.go Outdated
kindermoumoute and others added 6 commits March 10, 2020 17:28
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Co-Authored-By: Quentin Brosse <quentin.brosse@icloud.com>
Comment thread internal/core/arg_specs.go Outdated
Comment thread internal/core/arg_specs.go Outdated
Comment thread internal/core/testdata/test-positional-arg-full-command#01.stderr.golden Outdated
Comment thread internal/core/cobra_utils_test.go
Comment thread internal/core/arg_specs.go
kindermoumoute and others added 2 commits March 11, 2020 10:32
Co-Authored-By: Loïc Bourgois <loic@bourgois.pro>
Copy link
Copy Markdown
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit 2dbe16f into scaleway:v2 Mar 11, 2020
@kindermoumoute kindermoumoute deleted the positional-parameter branch March 11, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants