Skip to content

fix(instance): enhance server type listing#732

Merged
kindermoumoute merged 2 commits intoscaleway:v2from
kindermoumoute:list-server-types
Feb 28, 2020
Merged

fix(instance): enhance server type listing#732
kindermoumoute merged 2 commits intoscaleway:v2from
kindermoumoute:list-server-types

Conversation

@kindermoumoute
Copy link
Copy Markdown
Contributor

No description provided.


sort.Slice(serverTypes, func(i, j int) bool {
return serverTypes[i].Name < serverTypes[j].Name
catA := serverTypeCategory(serverTypes[i].Name)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catA -> categoryA

cat means "chat"

Copy link
Copy Markdown
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute merged commit f55fd82 into scaleway:v2 Feb 28, 2020
@kindermoumoute kindermoumoute deleted the list-server-types branch February 28, 2020 13:10
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants