Skip to content

baremetal: Add list server command#726

Merged
remyleone merged 7 commits intoscaleway:v2from
remyleone:baremetal
Mar 10, 2020
Merged

baremetal: Add list server command#726
remyleone merged 7 commits intoscaleway:v2from
remyleone:baremetal

Conversation

@remyleone
Copy link
Copy Markdown
Member

No description provided.

Comment thread cmd/scw/main.go Outdated
@jerome-quere
Copy link
Copy Markdown
Contributor

@remyleone can you fix goimports

@remyleone
Copy link
Copy Markdown
Member Author

@jerome-quere done

Comment thread internal/namespaces/baremetal/v1alpha1/baremetal_cli_test.go Outdated
Comment thread cmd/scw/main.go Outdated
kindermoumoute
kindermoumoute previously approved these changes Mar 6, 2020
Copy link
Copy Markdown
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread cmd/scw/testdata/test-all-usage-baremetal-ip-usage.stderr.golden Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/baremetal_cli_test.go Outdated
Comment thread internal/namespaces/instance/v1/testdata/test-list-server-simple.stdout.golden Outdated
Comment thread cmd/scw/main.go Outdated
Copy link
Copy Markdown
Contributor

@loicbourgois loicbourgois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit a5c017d into scaleway:v2 Mar 10, 2020
@remyleone remyleone added the elastic-metal Elastic-metal issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

elastic-metal Elastic-metal issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants