Skip to content

fix(login): add expires-at argument to scw login for API key expiration#5398

Merged
remyleone merged 7 commits intomainfrom
fix/scw-login-expires-at
Mar 19, 2026
Merged

fix(login): add expires-at argument to scw login for API key expiration#5398
remyleone merged 7 commits intomainfrom
fix/scw-login-expires-at

Conversation

@jremy42
Copy link
Copy Markdown
Contributor

@jremy42 jremy42 commented Mar 13, 2026

close #5397

@jremy42 jremy42 requested a review from remyleone as a code owner March 13, 2026 14:00
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.98%. Comparing base (019e26e) to head (5ea2856).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/namespaces/login/login.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5398      +/-   ##
==========================================
- Coverage   54.22%   50.98%   -3.24%     
==========================================
  Files         321      321              
  Lines       70970    75466    +4496     
==========================================
  Hits        38480    38480              
- Misses      31019    35515    +4496     
  Partials     1471     1471              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread internal/namespaces/login/login.go Outdated
@remyleone remyleone added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit df5c76c Mar 19, 2026
122 checks passed
@remyleone remyleone deleted the fix/scw-login-expires-at branch March 19, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scw login not working: expires_at missing

4 participants