chore: add support for user agent in s3client#5389
Merged
yfodil merged 1 commit intoscaleway:mainfrom Mar 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add a custom User-Agent entry to the AWS SDK v2 S3 client used by the object namespace, so S3 traffic can be attributed to the CLI and its version.
Changes:
- Extracts
BuildInfofrom context innewS3Client. - Adds an AWS SDK API middleware to append a User-Agent key/value to S3 requests.
- Wires the middleware through
s3.Options.APIOptions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5389 +/- ##
=======================================
Coverage 51.10% 51.10%
=======================================
Files 323 323
Lines 75301 75309 +8
=======================================
+ Hits 38480 38488 +8
Misses 35350 35350
Partials 1471 1471 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jremy42
reviewed
Mar 10, 2026
3632458 to
82a18d6
Compare
yfodil
approved these changes
Mar 23, 2026
estellesoulard
approved these changes
Mar 23, 2026
jremy42
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: