Skip to content

chore: add support for user agent in s3client#5389

Merged
yfodil merged 1 commit intoscaleway:mainfrom
remyleone:user_agent_object
Mar 23, 2026
Merged

chore: add support for user agent in s3client#5389
yfodil merged 1 commit intoscaleway:mainfrom
remyleone:user_agent_object

Conversation

@remyleone
Copy link
Copy Markdown
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Copilot AI review requested due to automatic review settings March 10, 2026 11:17
@remyleone remyleone requested a review from a team as a code owner March 10, 2026 11:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to add a custom User-Agent entry to the AWS SDK v2 S3 client used by the object namespace, so S3 traffic can be attributed to the CLI and its version.

Changes:

  • Extracts BuildInfo from context in newS3Client.
  • Adds an AWS SDK API middleware to append a User-Agent key/value to S3 requests.
  • Wires the middleware through s3.Options.APIOptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/namespaces/object/v1/s3_helpers.go Outdated
Comment thread internal/namespaces/object/v1/s3_helpers.go
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.10%. Comparing base (e096674) to head (82a18d6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5389   +/-   ##
=======================================
  Coverage   51.10%   51.10%           
=======================================
  Files         323      323           
  Lines       75301    75309    +8     
=======================================
+ Hits        38480    38488    +8     
  Misses      35350    35350           
  Partials     1471     1471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread internal/namespaces/object/v1/s3_helpers.go Outdated
@yfodil yfodil added this pull request to the merge queue Mar 23, 2026
Merged via the queue into scaleway:main with commit 0b8c1aa Mar 23, 2026
121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants