Skip to content

feat(instance): get server-type list info from PCU#5379

Merged
remyleone merged 1 commit intoscaleway:mainfrom
Mia-Cross:instance_server_type_switch_to_pcu
Mar 11, 2026
Merged

feat(instance): get server-type list info from PCU#5379
remyleone merged 1 commit intoscaleway:mainfrom
Mia-Cross:instance_server_type_switch_to_pcu

Conversation

@Mia-Cross
Copy link
Copy Markdown
Contributor

@Mia-Cross Mia-Cross commented Mar 4, 2026

This PR changes the source of information to display for the scw instance server-type list command from the Instance API to the PCU. This will harmonize the pricing between the DevTools and the Console.

The command will display server types with the following statuses:

  • public_beta
  • preview
  • general_availability
  • end_of_new_features

Other changes include:

  • replacing Local Volume Max Size field with Supported Storage (for human output only, both fields will be available in json output)
  • adding Bandwidth field

Closes #5076

@Mia-Cross Mia-Cross self-assigned this Mar 4, 2026
@Mia-Cross Mia-Cross added bug instance Instance issues, bugs and feature requests priority:medium Improvements that are not the main priority labels Mar 4, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 79.41176% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.56%. Comparing base (e0b1670) to head (d6b7daa).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ernal/namespaces/instance/v1/custom_server_type.go 79.20% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5379   +/-   ##
=======================================
  Coverage   54.55%   54.56%           
=======================================
  Files         317      317           
  Lines       70463    70500   +37     
=======================================
+ Hits        38444    38470   +26     
- Misses      30549    30559   +10     
- Partials     1470     1471    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross force-pushed the instance_server_type_switch_to_pcu branch from 1e72219 to d6b7daa Compare March 11, 2026 11:20
@Mia-Cross Mia-Cross marked this pull request as ready for review March 11, 2026 13:29
@Mia-Cross Mia-Cross requested a review from a team as a code owner March 11, 2026 13:29
@remyleone remyleone added this pull request to the merge queue Mar 11, 2026
Merged via the queue into scaleway:main with commit f865d4c Mar 11, 2026
120 checks passed
@Mia-Cross Mia-Cross deleted the instance_server_type_switch_to_pcu branch March 11, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug instance Instance issues, bugs and feature requests priority:medium Improvements that are not the main priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pricing seems incorrect in 'instance server-type list'

3 participants