Skip to content

chore(k8s): deprecate replace on DeleteNode #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yfodil merged 1 commit into from
Mar 4, 2026
+0 −21
Merged

chore(k8s): deprecate replace on DeleteNode #5377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cmd/scw/testdata/test-all-usage-k8s-node-delete-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,9 @@ EXAMPLES:
Delete a node without evicting workloads
scw k8s node delete 11111111-1111-1111-1111-111111111111 skip-drain=true

Replace a node by a new one
scw k8s node delete 11111111-1111-1111-1111-111111111111 replace=true

ARGS:
node-id ID of the node to replace
[skip-drain] Skip draining node from its workload (Note: this parameter is currently inactive)
[replace] Add a new node after the deletion of this node
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
6 changes: 0 additions & 6 deletions docs/commands/k8s.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,6 @@ scw k8s node delete <node-id ...> [arg=value ...]
|------|---|-------------|
| node-id | Required | ID of the node to replace |
| skip-drain | | Skip draining node from its workload (Note: this parameter is currently inactive) |
| replace | | Add a new node after the deletion of this node |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand All @@ -784,11 +783,6 @@ Delete a node without evicting workloads
scw k8s node delete 11111111-1111-1111-1111-111111111111 skip-drain=true
```

Replace a node by a new one
```
scw k8s node delete 11111111-1111-1111-1111-111111111111 replace=true
```




Expand Down
11 changes: 0 additions & 11 deletions internal/namespaces/k8s/v1/k8s_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2515,13 +2515,6 @@ func k8sNodeDelete() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "replace",
Short: `Add a new node after the deletion of this node`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand All @@ -2545,10 +2538,6 @@ func k8sNodeDelete() *core.Command {
Short: "Delete a node without evicting workloads",
Raw: `scw k8s node delete 11111111-1111-1111-1111-111111111111 skip-drain=true`,
},
{
Short: "Replace a node by a new one",
Raw: `scw k8s node delete 11111111-1111-1111-1111-111111111111 replace=true`,
},
},
}
}
Expand Down
Loading