Skip to content

feat(datawarehouse): add datawarehouse support#5294

Merged
remyleone merged 1 commit intoscaleway:masterfrom
remyleone:fix_dwh
Jan 23, 2026
Merged

feat(datawarehouse): add datawarehouse support#5294
remyleone merged 1 commit intoscaleway:masterfrom
remyleone:fix_dwh

Conversation

@remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Copilot AI review requested due to automatic review settings January 23, 2026 13:14
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.88%. Comparing base (2d6e718) to head (fe338ca).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nternal/namespaces/datawarehouse/v1beta1/custom.go 0.00% 4 Missing ⚠️
commands/commands.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5294      +/-   ##
==========================================
- Coverage   55.88%   55.88%   -0.01%     
==========================================
  Files         316      317       +1     
  Lines       71631    71636       +5     
==========================================
  Hits        40032    40032              
- Misses      30104    30109       +5     
  Partials     1495     1495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Scaleway Data Warehouse (scw datawarehouse) support to the CLI, including command registration, generated documentation, and updated usage fixtures.

Changes:

  • Register the new datawarehouse namespace and place it under the database command group.
  • Add autogenerated command documentation for scw datawarehouse.
  • Add/update CLI usage golden test fixtures for datawarehouse commands.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
internal/namespaces/datawarehouse/v1beta1/custom.go Wires generated Data Warehouse commands into the CLI and assigns the database group.
docs/commands/datawarehouse.md Adds autogenerated markdown docs for scw datawarehouse and subcommands.
commands/commands.go Registers datawarehouse.GetCommands() in the global CLI command set.
cmd/scw/testdata/test-main-usage-usage.golden Updates top-level CLI usage output to include datawarehouse under DATABASE COMMANDS.
cmd/scw/testdata/test-all-usage-datawarehouse-usage.golden Adds golden output for scw datawarehouse help.
cmd/scw/testdata/test-all-usage-datawarehouse-database-usage.golden Adds golden output for scw datawarehouse database help.
cmd/scw/testdata/test-all-usage-datawarehouse-database-create-usage.golden Adds golden output for scw datawarehouse database create help.
cmd/scw/testdata/test-all-usage-datawarehouse-database-delete-usage.golden Adds golden output for scw datawarehouse database delete help.
cmd/scw/testdata/test-all-usage-datawarehouse-database-list-usage.golden Adds golden output for scw datawarehouse database list help.
cmd/scw/testdata/test-all-usage-datawarehouse-deployment-usage.golden Adds golden output for scw datawarehouse deployment help.
cmd/scw/testdata/test-all-usage-datawarehouse-deployment-create-usage.golden Adds golden output for scw datawarehouse deployment create help.
cmd/scw/testdata/test-all-usage-datawarehouse-deployment-delete-usage.golden Adds golden output for scw datawarehouse deployment delete help.
cmd/scw/testdata/test-all-usage-datawarehouse-deployment-get-usage.golden Adds golden output for scw datawarehouse deployment get help.
cmd/scw/testdata/test-all-usage-datawarehouse-deployment-list-usage.golden Adds golden output for scw datawarehouse deployment list help.
cmd/scw/testdata/test-all-usage-datawarehouse-deployment-update-usage.golden Adds golden output for scw datawarehouse deployment update help.
cmd/scw/testdata/test-all-usage-datawarehouse-endpoint-usage.golden Adds golden output for scw datawarehouse endpoint help.
cmd/scw/testdata/test-all-usage-datawarehouse-preset-usage.golden Adds golden output for scw datawarehouse preset help.
cmd/scw/testdata/test-all-usage-datawarehouse-preset-list-usage.golden Adds golden output for scw datawarehouse preset list help.
cmd/scw/testdata/test-all-usage-datawarehouse-user-usage.golden Adds golden output for scw datawarehouse user help.
cmd/scw/testdata/test-all-usage-datawarehouse-user-create-usage.golden Adds golden output for scw datawarehouse user create help.
cmd/scw/testdata/test-all-usage-datawarehouse-user-delete-usage.golden Adds golden output for scw datawarehouse user delete help.
cmd/scw/testdata/test-all-usage-datawarehouse-user-list-usage.golden Adds golden output for scw datawarehouse user list help.
cmd/scw/testdata/test-all-usage-datawarehouse-user-update-usage.golden Adds golden output for scw datawarehouse user update help.
cmd/scw/testdata/test-all-usage-datawarehouse-version-usage.golden Adds golden output for scw datawarehouse version help.
cmd/scw/testdata/test-all-usage-datawarehouse-version-list-usage.golden Adds golden output for scw datawarehouse version list help.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

func GetCommands() *core.Commands {
cmds := GetGeneratedCommands()

cmds.MustFind("datawarehouse").Groups = []string{"database"}
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI exposes a top-level datawarehouse endpoint command, but it has no subcommands and no action (it only shows help). If endpoint operations aren't supported yet, consider hiding this command (cmd.Hidden = true) until real endpoint verbs exist, to avoid shipping a non-functional surface area.

Suggested change
cmds.MustFind("datawarehouse").Groups = []string{"database"}
cmds.MustFind("datawarehouse").Groups = []string{"database"}
cmds.MustFind("datawarehouse", "endpoint").Hidden = true

Copilot uses AI. Check for mistakes.
Comment on lines +223 to +224
Manage endpoints associated with a deployment.

Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Endpoint section repeats the same description twice, which looks like a doc-gen artifact and makes the rendered docs noisy. Please remove the duplicate sentence (or adjust the doc generator/template so it only renders the section description once).

Suggested change
Manage endpoints associated with a deployment.

Copilot uses AI. Check for mistakes.



## List available Clickhouse® versions
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading uses "Clickhouse®" (lowercase 'h'), while the product branding elsewhere (including the subsection title right below) uses "ClickHouse®". Please standardize the title/TOC entry to "ClickHouse®" by fixing the source command metadata so regenerated docs and help output are consistent.

Suggested change
## List available Clickhouse® versions
## List available ClickHouse® versions

Copilot uses AI. Check for mistakes.
cmds := GetGeneratedCommands()

cmds.MustFind("datawarehouse").Groups = []string{"database"}

Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "preset" and "version" resource commands currently have the same Short text as their only subcommand ("list"), which produces duplicated entries/headings in generated docs (and makes the help output less clear). Consider overriding the resource command Short values in this custom.go to follow the established pattern (e.g. "Preset management commands" / "ClickHouse® version management commands"), so the leaf command keeps the "List ..." wording.

Suggested change
// Override resource command Short descriptions to avoid duplication with their subcommands.
cmds.MustFind("datawarehouse", "preset").Short = "Preset management commands"
cmds.MustFind("datawarehouse", "version").Short = "ClickHouse® version management commands"

Copilot uses AI. Check for mistakes.
@remyleone remyleone added this pull request to the merge queue Jan 23, 2026
Merged via the queue into scaleway:master with commit fccdbeb Jan 23, 2026
129 checks passed
@remyleone remyleone deleted the fix_dwh branch January 23, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants